Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset stale SSH_TTY environment variable #1187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProducerMatt
Copy link

This variable would confuse devices that relied on it, such as the Clipetty extension for Emacs. See issue #1134.

Tested on my end, I can now use Clipetty without needing to detect Mosh's existence and unset the variable manually. LMK if I did anything incorrectly.

This variable would confuse devices that relied on it, such as the Clipetty extension for Emacs. See issue mobile-shell#1134
@carloscabanero
Copy link

This environment variable may also interfere with other commands that check if they are being run within a SSH session (ie, https://github.com/theimpostor/osc). Because the SSH_TTY dies with the SSH command, it does not make sense for mosh to inherit it.

I tried to remove this on the client side when calling mosh-server, but the result was not portable.

The patch is consistent with the previous "STY" unset. Is there anything I can do to help merge this?

@bionade24
Copy link

+1 for merging this. Please give some explanation if you don't want to merge this and close the PR.

@ProducerMatt
Copy link
Author

ProducerMatt commented Jun 25, 2024

@Chutdafugkup sorry for accidentally requesting a review. I can't tell what your review was (an approval, a comment, etc) and I hit the request button while fumbling around trying to figure it out.

msva added a commit to alphallc/mosh that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants