GitHub actions #1170
Merged
GitHub actions #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezzieyguywuf
force-pushed
the
github_actions
branch
7 times, most recently
from
42ee2fc to
23eab0b
Compare
|
@achernya can you please review this PR? |
achernya
requested changes
Jan 30, 2022
ezzieyguywuf
force-pushed
the
github_actions
branch
3 times, most recently
from
c200830 to
00acabd
Compare
Signed-off-by: Wolfgang E. Sanyer <[email protected]>
Signed-off-by: Wolfgang E. Sanyer <[email protected]>
Signed-off-by: Wolfgang E. Sanyer <[email protected]>
ezzieyguywuf
force-pushed
the
github_actions
branch
from
00acabd to
88c20b7
Compare
|
@achernya I believe I've addressed all your original comments. Can you let me know if there's anything else blocking this from moving forward? |
achernya
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a github action to
Mosh on both macos and ubuntu
Currently, the macos build seems to be failing,
maybe due to 6fe7cde, though this still requires further investigationactually, I think the failure is due to this protobuf commit as discussed here