Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed in favor of #1292 #1167

Closed
wants to merge 1 commit into from

Conversation

matheusfillipe
Copy link

Fixes #1084

@aurelienbottazini
Copy link

aurelienbottazini commented Dec 12, 2021

Works for me

from OSX + iterm -> to Ubuntu 20.10

@fbernier
Copy link

fbernier commented Feb 1, 2022

This fixes the issue for me too.

Arch + alacritty -> arch + alacritty

@demon386
Copy link

demon386 commented Feb 6, 2022

+1

@jeremybahadirli
Copy link

Any idea whether this is slated to be merged prior to the Mosh 1.4 release?

@achernya
Copy link
Collaborator

My plan is for 1.4 to be a release of existing merged commits and a future release will include any outstanding PRs

lilydjwg added a commit to archlinuxcn/repo that referenced this pull request Sep 18, 2022
@martijk
Copy link

martijk commented Nov 12, 2022

It doesn't seem to do anything for me with kitty or Tilix and the patch applied on both sides on top of mosh-stable. What I did to test:

  • printf '\x1b]12;%s\a' '#ffffe4e4c4c4'
  • use the Terminus VIM plugin, which changes the cursor shape based on the mode

The client side is Fedora 37, server side RHEL 8. Command that I used: /local/path/to/patched/mosh --server=/remote/path/to/patched/mosh-server <server>.

@lifei
Copy link

lifei commented May 18, 2023

any update?

jdrouhard added a commit to jdrouhard/mosh that referenced this pull request May 20, 2023
eggbean added a commit to eggbean/.dotfiles that referenced this pull request Jun 27, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
eggbean added a commit to eggbean/.dotfiles that referenced this pull request Jul 2, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
eggbean added a commit to eggbean/.dotfiles that referenced this pull request Jul 5, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
@bcp-dev-ops
Copy link

is it possible to merge?

eggbean added a commit to eggbean/.dotfiles that referenced this pull request Aug 6, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
eggbean added a commit to eggbean/.dotfiles that referenced this pull request Aug 8, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
jdrouhard added a commit to jdrouhard/mosh that referenced this pull request Aug 20, 2023
@MahdiNazemi
Copy link

MahdiNazemi commented Aug 30, 2023

Would it be possible for someone familiar with the code to update this PR to resolve its merge conflicts with the master branch?
I attempted twice but it looks like some files like shared.h no longer exist in the master branch.
shared.h is no longer needed (shared pointers are used from the standard library).

@matheusfillipe matheusfillipe changed the title Improve cursor style handling Closed in favor of https://github.com/mobile-shell/mosh/pull/1292 Sep 11, 2023
@matheusfillipe matheusfillipe changed the title Closed in favor of https://github.com/mobile-shell/mosh/pull/1292 Closed in favor of 292 Sep 11, 2023
@matheusfillipe matheusfillipe changed the title Closed in favor of 292 Closed in favor of #292 Sep 11, 2023
@matheusfillipe
Copy link
Author

#1292

eggbean added a commit to eggbean/.dotfiles that referenced this pull request Oct 26, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
eggbean added a commit to eggbean/.dotfiles that referenced this pull request Nov 12, 2023
Made using my forked mosh-multiarch github action with added patch from
my forked mosh repo.

https://github.com/eggbean/mosh-static-multiarch
https://github.com/eggbean/mosh

Patched for improved cursor style handling
mobile-shell/mosh#1167
@martijk
Copy link

martijk commented Jan 2, 2024

It doesn't seem to do anything for me with kitty or Tilix and the patch applied on both sides on top of mosh-stable. What I did to test:

* `printf '\x1b]12;%s\a' '#ffffe4e4c4c4'`

* use the [Terminus VIM plugin](https://github.com/wincent/terminus), which changes the cursor shape based on the mode

The client side is Fedora 37, server side RHEL 8. Command that I used: /local/path/to/patched/mosh --server=/remote/path/to/patched/mosh-server <server>.

It does work, or at least with #1292. The issue was that the bin directory of the patched mosh wasn't in my path, which probably meant that it was executing mosh-client from my system installation.

@eggbean
Copy link

eggbean commented Jan 2, 2024

I find that /usr/local/bin is a good location that overrides package installed software.

(Sorry about all the above references to this thread. That repository was private before, but now they are visible as it's public)

@dechimp
Copy link

dechimp commented Sep 5, 2024

title should read #1292, not #292

@matheusfillipe matheusfillipe changed the title Closed in favor of #292 Closed in favor of #1292 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor style not handled correctly