[MA-2561] Bad requests for inputText and eraseText if keyboard is not present #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
herval
reviewed
Dec 6, 2024
amanjeetsingh150
force-pushed
the
MA-2561
branch
from
a922941 to
6cad0b2
Compare
proksh
approved these changes
Dec 9, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the keyboard is not present on the screen the call to inputText and eraseText leads to a timeout which then becomes an infra error.
This change:
Testing
Issues fixed