Add null check in childNafCheck to handle case when child node is null #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leland-Takamine
requested review from
herval,
dmitry-zaitsev and
amanjeetsingh150
dmitry-zaitsev
approved these changes
Dec 3, 2024
|
Nice 🙌 Can you run: That should copy the new servers and host APKs to the directories itself. We should probably automate this, will create a ticket for this. |
amanjeetsingh150
approved these changes
Dec 4, 2024
|
When you get those binaries in, the E2E Test should pass, right? |
Correct right now the driver is not updated. Good idea to update it and see if it's not there anymore in E2E tests. I see that its actually reproducible here as well. |
Fishbowler
approved these changes
Dec 4, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
mobile-dev-inc#2172) * Add null check in childNafCheck to handle case when child node is null * Update build artefacts --------- Co-authored-by: Dan Caseley <[email protected]>
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
mobile-dev-inc#2172) * Add null check in childNafCheck to handle case when child node is null * Update build artefacts --------- Co-authored-by: Dan Caseley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing this NPE show up in Maestro Cloud and Robin. Incorporating this AOSP fix that didn't exist when the code was copied over into Maestro: https://android-review.googlesource.com/c/platform/frameworks/support/+/2631315/2/test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/AccessibilityNodeInfoDumper.java