Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More e2e tests #2124

Merged
merged 7 commits into from
Nov 24, 2024
Merged

More e2e tests #2124

merged 7 commits into from
Nov 24, 2024

Conversation

Fishbowler
Copy link
Contributor

@Fishbowler Fishbowler commented Nov 3, 2024

Adds additional e2e tests:

  • A tour of most commands and their options
  • A few additional expected failure cases

Testing

  • maestro test e2e/workspaces/demo_app/commands_tour.yaml
  • See the CI run :)

@Fishbowler Fishbowler force-pushed the more-e2e-tests branch 6 times, most recently from a5d4b95 to 56e3b1d Compare November 11, 2024 16:56
@Fishbowler Fishbowler force-pushed the more-e2e-tests branch 2 times, most recently from f692094 to 44414f3 Compare November 21, 2024 19:44
@Fishbowler Fishbowler force-pushed the more-e2e-tests branch 3 times, most recently from d1adf24 to 7f6c4c0 Compare November 21, 2024 21:03
@Fishbowler Fishbowler marked this pull request as ready for review November 22, 2024 09:39
Copy link
Contributor

@axelniklasson axelniklasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🙌 Are we planning to add iOS support for the same command next?

@Fishbowler
Copy link
Contributor Author

💯.

As well as more, and more representative Android.

Copy link
Contributor

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to say this is so nice to see :)

@Fishbowler Fishbowler merged commit a64aaa4 into mobile-dev-inc:main Nov 24, 2024
8 checks passed
@Fishbowler Fishbowler deleted the more-e2e-tests branch November 24, 2024 14:50
rasyid7 pushed a commit to rasyid7/maestro that referenced this pull request Dec 9, 2024
* Add additional failure e2e tests for different assert commands

* Add additional failure e2e tests for launching apps

* Add e2e test to tour commands

* Fix escaping of structured logging in e2e tests

* Allow e2e-tests longer to run

* Relax timings on extendedWaitUntil e2e test

* Relax tap retries when waiting for repaint
rasyid7 pushed a commit to rasyid7/maestro that referenced this pull request Dec 9, 2024
* Add additional failure e2e tests for different assert commands

* Add additional failure e2e tests for launching apps

* Add e2e test to tour commands

* Fix escaping of structured logging in e2e tests

* Allow e2e-tests longer to run

* Relax timings on extendedWaitUntil e2e test

* Relax tap retries when waiting for repaint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants