Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for the new, not-yet-released version #2018

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

bartekpacia
Copy link
Contributor

No description provided.

@bartekpacia bartekpacia changed the title Add changelog for the newly unreleased version Add changelog for the new, unreleased-yet version Sep 5, 2024
@bartekpacia bartekpacia changed the title Add changelog for the new, unreleased-yet version Add changelog for the new, not-yet-released version Sep 5, 2024
@bartekpacia
Copy link
Contributor Author

bartekpacia commented Sep 5, 2024

@tokou fyi: the changelog test if failing

will look into it

@bartekpacia
Copy link
Contributor Author

@tokou Ah, it's failing because I retroactively changed the changelog for v1.38.1. So it's all fine.

@bartekpacia
Copy link
Contributor Author

I don't like that changelog must now be written in a quite rigid way, to make sure it displays correctly in the CLI.

I believe a link to the latest version should suffice.

@bartekpacia bartekpacia merged commit 9d81a85 into main Sep 5, 2024
6 checks passed
@bartekpacia bartekpacia deleted the update_changelog branch September 5, 2024 14:13
@tokou
Copy link
Contributor

tokou commented Sep 5, 2024

I don't like that changelog must now be written in a quite rigid way, to make sure it displays correctly in the CLI.

@bartekpacia I back tested it with a lot of the older versions and it still shows something decent
Basically, it takes only the first level bullet points and ignores anything else, and changelog will always have those (and they're the most meaningful info)

@bartekpacia
Copy link
Contributor Author

Yeah, I thought about this more and I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants