Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no tests being run when flowsOrder specified all tests in the workspace #2003

Merged
merged 16 commits into from
Sep 3, 2024

Conversation

bartekpacia
Copy link
Contributor

Attempts to fix #1971

@bartekpacia
Copy link
Contributor Author

Investigation results

This bug is introduced by #1732. Offending source code:

val effectiveShards = shards.coerceAtMost(plan.flowsToRun.size)
val chunkPlans = plan.flowsToRun

It occurs only when all flows are specified in executionOrder.flowsOrder. Take this config.yaml as an example:

flows:
  - "features/**"
includeTags:
  - regression
executionOrder:
    continueOnFailure: true
    flowsOrder:
        - test1
        - test2
        - test3

If in features/ there is only test1.yaml, test2.yaml, and test3.yaml, then the bug occurs. But if we add test_other.yaml, then the bug is fixed.

Fix: when running in a single shard, add ExecutionPlan.sequence at the beginning of the queue of flows to execute.

Also, I'd like to have a bit more output logging.

@bartekpacia bartekpacia changed the title Start reproducing flowsOrder not working Fix no tests being run when flowsOrder specified all tests in the workspace Sep 3, 2024
@bartekpacia bartekpacia merged commit 3384806 into main Sep 3, 2024
5 checks passed
@bartekpacia bartekpacia deleted the fix/flows_order branch September 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flowsOrder doesn't work in 1.37.9
1 participant