-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout not working in scrollUntilVisible #2108
Comments
vibin
added a commit
to vibin/maestro
that referenced
this issue
Oct 23, 2024
The `timeout` in ScrollUntilVisibleCommand should be interpreted as milliseconds: https://maestro.mobile.dev/api-reference/commands/scrolluntilvisible Fixes mobile-dev-inc#2108. This was broken by mobile-dev-inc#2023.
@bartekpacia fixed this in #2112. |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue. |
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this issue
Dec 9, 2024
* Fix timeout unit in ScrollUntilVisibleCommand The `timeout` in ScrollUntilVisibleCommand should be interpreted as milliseconds: https://maestro.mobile.dev/api-reference/commands/scrolluntilvisible Fixes mobile-dev-inc#2108. This was broken by mobile-dev-inc#2023.
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this issue
Dec 9, 2024
* Fix timeout unit in ScrollUntilVisibleCommand The `timeout` in ScrollUntilVisibleCommand should be interpreted as milliseconds: https://maestro.mobile.dev/api-reference/commands/scrolluntilvisible Fixes mobile-dev-inc#2108. This was broken by mobile-dev-inc#2023.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is there an existing issue for this?
Steps to reproduce
Actual results
As easy as it sounds, the timeout parameter does not work for the method scrollUntilVisible, Maestro keeps scrolling forever.
Expected results
I expect the test to fail after the timeout duration.
About app
Native app for android mobile in ReactNative.
About environment
Pixel 9 Pro API35 from AndroidStudio.
Logs
No response
Maestro version
1.39.0
How did you install Maestro?
Homebrew
Anything else?
No response
The text was updated successfully, but these errors were encountered: