[MA 2747] Check keyboard existence in all foreground apps (#2184)

* fix: check keyboard presence in all foreground apps

* fix: list all running apps as well

maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt

@@ -44,7 +44,7 @@ object XCRunnerCLIUtils {
         val mapper = jacksonObjectMapper()
         val appsMap = mapper.readValue(json, Map::class.java) as Map<String, Any>
 
-        return appsMap.keys
+        return appsMap.keys + runningApps(deviceId).keys
     }
 
     fun setProxy(host: String, port: Int) {

maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/Handlers/EraseTextHandler.swift

@@ -19,8 +19,7 @@ struct EraseTextHandler: HTTPHandler {
         do {
             let start = Date()
 
-            let appId = RunningApp.getForegroundAppId(requestBody.appIds)
-            if let errorResponse = await waitUntilKeyboardIsPresented(appId: appId) {
+            if let errorResponse = await waitUntilKeyboardIsPresented(appIds: requestBody.appIds) {
                 return errorResponse
             }
 
@@ -37,10 +36,14 @@ struct EraseTextHandler: HTTPHandler {
         }
     }
 
-    private func waitUntilKeyboardIsPresented(appId: String?) async -> HTTPResponse? {
+    private func waitUntilKeyboardIsPresented(appIds: [String]) async -> HTTPResponse? {
+        let foregroundAppIds = RunningApp.getForegroundAppIds(appIds)
+        logger.info("Foreground apps \(foregroundAppIds)")
+
         let isKeyboardPresented: Bool = (try? await TimeoutHelper.repeatUntil(timeout: 1, delta: 0.2) {
-            guard let appId = appId else { return true }
-            return XCUIApplication(bundleIdentifier: appId).keyboards.firstMatch.exists
+            return foregroundAppIds.contains { appId in
+                XCUIApplication(bundleIdentifier: appId).keyboards.firstMatch.exists
+            }
         }) ?? false
 
         // Return an error response if the keyboard is not presented

maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/Handlers/InputTextRouteHandler.swift

@@ -17,8 +17,7 @@ struct InputTextRouteHandler : HTTPHandler {
         do {
             let start = Date()
 
-            let appId = RunningApp.getForegroundAppId(requestBody.appIds)
-            if let errorResponse = await waitUntilKeyboardIsPresented(appId: appId) {
+            if let errorResponse = await waitUntilKeyboardIsPresented(appIds: requestBody.appIds) {
                 return errorResponse
             }
 
@@ -32,10 +31,14 @@ struct InputTextRouteHandler : HTTPHandler {
         }
     }
 
-    private func waitUntilKeyboardIsPresented(appId: String?) async -> HTTPResponse? {
+    private func waitUntilKeyboardIsPresented(appIds: [String]) async -> HTTPResponse? {
+        let foregroundAppIds = RunningApp.getForegroundAppIds(appIds)
+        logger.info("Foreground apps \(foregroundAppIds)")
+
         let isKeyboardPresented: Bool = (try? await TimeoutHelper.repeatUntil(timeout: 1, delta: 0.2) {
-            guard let appId = appId else { return true }
-            return XCUIApplication(bundleIdentifier: appId).keyboards.firstMatch.exists
+            return foregroundAppIds.contains { appId in
+                XCUIApplication(bundleIdentifier: appId).keyboards.firstMatch.exists
+            }
         }) ?? false
 
         // Return an error response if the keyboard is not presented

maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/XCTest/RunningApp.swift

@@ -24,5 +24,14 @@ struct RunningApp {
         } ?? RunningApp.springboardBundleId
     }
 
-
+    static func getForegroundAppIds(_ appIds: [String]) -> [String] {
+        // springboard is always on foreground
+        let allAppIds = appIds + ["com.apple.springboard"]
+
+
+        return allAppIds.filter { appId in
+            let app = XCUIApplication(bundleIdentifier: appId)
+            return app.state == .runningForeground
+        }
+    }
 }