allow remote xctest connections w/ a flag

mobile-dev-inc · Dec 9, 2024 · 0fc18a7 · 0fc18a7
1 parent c7e9fb9
commit 0fc18a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt b/maestro-ios-driver/src/main/kotlin/util/XCRunnerCLIUtils.kt
@@ -121,7 +121,7 @@ object XCRunnerCLIUtils {
         return runningApps(deviceId)[bundleId]
     }
 
-    fun runXcTestWithoutBuild(deviceId: String, xcTestRunFilePath: String, port: Int, enableXCTestOutputFileLogging: Boolean = false): Process {
+    fun runXcTestWithoutBuild(deviceId: String, xcTestRunFilePath: String, port: Int, enableXCTestOutputFileLogging: Boolean = false, acceptRemoteConnections: Boolean = false): Process {
         val date = dateFormatter.format(LocalDateTime.now())
         val outputFile = if (enableXCTestOutputFileLogging) {
             File(logDirectory, "xctest_runner_$date.log")
@@ -142,7 +142,7 @@ object XCRunnerCLIUtils {
             ),
             waitForCompletion = false,
             outputFile = outputFile,
-            params = mapOf("TEST_RUNNER_PORT" to port.toString())
+            params = mapOf("TEST_RUNNER_PORT" to port.toString(), "ACCEPT_REMOTE_CONNECTIONS" to acceptRemoteConnections.toString())
         )
     }
 }
diff --git a/maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt b/maestro-ios-driver/src/main/kotlin/xcuitest/installer/LocalXCTestInstaller.kt
@@ -30,6 +30,7 @@ class LocalXCTestInstaller(
         connectTimeout = 1.seconds,
         readTimeout = 100.seconds,
     ),
+    private val acceptRemoteConnections: Boolean = false,
     ) : XCTestInstaller {
 
     private val logger = LoggerFactory.getLogger(LocalXCTestInstaller::class.java)
@@ -202,6 +203,7 @@ class LocalXCTestInstaller(
             xcTestRunFilePath = xctestRunFile.absolutePath,
             port = defaultPort,
             enableXCTestOutputFileLogging = enableXCTestOutputFileLogging,
+            acceptRemoteConnections = acceptRemoteConnections,
         )
         logger.info("[Done] Running XcUITest with `xcodebuild test-without-building`")
     }

diff --git a/maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/XCTestHTTPServer.swift b/maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/XCTestHTTPServer.swift
@@ -28,7 +28,7 @@ struct XCTestHTTPServer {
         let port = ProcessInfo.processInfo.environment["PORT"]?.toUInt16()
         let acceptRemoteConnections = ProcessInfo.processInfo.environment["ACCEPT_REMOTE_CONNECTIONS"] == "true"
 
-        let address: HTTPServer.Address = acceptRemoteConnections ? .any(port: port) : .loopback(port: port)
+        let address = acceptRemoteConnections ? .inet(port: port) : .loopback(port: port)
 
         for route in Route.allCases {
             let handler = await RouteHandlerFactory.createRouteHandler(route: route)