This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently blocked by an issue with Velocity's jQuery shim on iOS6: julianshapiro/velocity#208 Once this is fixed, we should be Good to Merge™. |
Tried this with AdaptiveJS 1.0 and received an error:
Velocity is what looks to be undefined in this case. My require config:
|
Try now! |
* is not available.
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of bellows using new plugin format.
Status: Ready to merge
Reviewers: @jansepar @tedtate @donnielrt @kpeatt
JIRA: https://mobify.atlassian.net/browse/CSOPS-80
Changes
How to test-drive this PR
npm install && bower install
grunt test
grunt serve