Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable softening completely #98

Closed
BenWoodford opened this issue Jul 23, 2020 · 7 comments
Closed

Option to disable softening completely #98

BenWoodford opened this issue Jul 23, 2020 · 7 comments
Assignees
@mob-sakai
Labels
enhancement New feature or request released on @preview

Comments

@BenWoodford
Copy link

Is your feature request related to a problem? Please describe.
The below happens when using a hard-edged mask (Unity's own mask doesn't support overlapping masks where it only masks the children, so having two images "splitscreen" style diagonally isn't terribly easy)

image

The masks for context

image

Even at 0.01 softness it gives a soft-edged look.

Describe the solution you'd like
The option to completely disable softening and just utilise the other features of the component (like the better hierarchical masking)
@BenWoodford BenWoodford added the enhancement New feature or request label Jul 23, 2020
@mob-sakai
Copy link
Owner

@BenWoodford
Try increasing the texture resolution of the SpellMask-***.

@BenWoodford
Copy link
Author

They were 1024x1024 so already pretty big. However more curiously, as had switched back to using Mask and only masking one half of the square (and toggling it as necessary)... when I switched back to the soft mask it suddenly isn't working and the buffer shows nothing in it. That's weird...

image

@mob-sakai
Copy link
Owner

I would like to know more about this issue.

Could you please attach a minimal project (included Assets and ProjectSettings directory) that reproduces the issue?

@mob-sakai
Copy link
Owner

If you want a hard edge, Unity Default Masks are the easiest option:


NOTE: Set the Filter Mode to Pointer (no filter) in the import settings of mask textures.

issue98.unitypackage.zip

@BenWoodford
Copy link
Author

I’ll see what I can do but as it occurred randomly I’m not sure how easy it’ll be to recreate it in a stand-alone project. Using Unity masks isn’t really viable in all scenarios as Unity doesn’t obey hierarchies for masks - two siblings will act as one mask I’ve found. Whereas your system does obey the hierarchy and only mask children

@mob-sakai
Copy link
Owner

Sorry for late reply.
It seems desirable to support Softness=0.

mob-sakai added a commit that referenced this issue Sep 8, 2020
@mob-sakai
feat: option to disable softening completely
dedd847 
close #98
github-actions bot pushed a commit that referenced this issue Sep 8, 2020
@semantic-release-bot
1.0.0-preview.8
58eeefc 
# [1.0.0-preview.8](v1.0.0-preview.7...v1.0.0-preview.8) (2020-09-08)

### Features

* if the 'UIMask' sprite is specified as the source image, it is suggested to use another image ([ea904db](ea904db)), closes [#82](#82)
* option to disable softening completely ([dedd847](dedd847)), closes [#98](#98)
* use the stencil buffer outside the scene view canvas for editing ([dbab85c](dbab85c)), closes [#100](#100)
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

🎉 This issue has been resolved in version 1.0.0-preview.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
enhancement New feature or request released on @preview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenWoodford @mob-sakai