Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md with grammar update #231

Closed
wants to merge 1 commit into from

Conversation

JeffJeff4252
Copy link

Description

Related Issues

How can it be tested?

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 11:38pm

Copy link
Contributor

@brunobuddy brunobuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JeffJeff4252

Thank you for your contribution ! I think the correct form is "have written" if my English is correct.

@JeffJeff4252
Copy link
Author

Hello @brunobuddy

Both work.

@brunobuddy
Copy link
Contributor

@JeffJeff4252 chatgpt does not agree

The correct form depends on the tense you're aiming to use. Here's a breakdown:

Correct form:

"I have written" (present perfect tense)
Example: I have written a book.
"I wrote" (simple past tense):
Use this if you're talking about a specific past action.
Example: I wrote an email yesterday.

Why?
"Wrote" is the past tense of write.
"Written" is the past participle, which is used with auxiliary verbs like have or has.
Let me know if you'd like more examples! 😊

@brunobuddy
Copy link
Contributor

I am closing this PR as it is does not solve any problem

@brunobuddy brunobuddy closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants