-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH, WIP: Spectrogram mode, minimal version #272
base: main
Are you sure you want to change the base?
Conversation
|
I would say at a minimum you'd need some way to specify / change the frequency range and the colormap limits. Seems like maybe a new dedicated TFR / spectrogram dialog might be needed, or if it's just a few options more rows in the existing Settings dialog could work |
I'm already expanding the settings dialog quite a bit with my project. Maybe we should add to remove channel scaling/sensitivity when in spectrogram mode? Probably isn't useful in this scenario. |
Yeah it probably does make sense to show/hide based on viewing mode at some point. For now though I think it's okay to keep adding stuff and we can decide later what makes the most sense to show when, or whether to use tabs or different dialogs, etc. Make it work then make it pretty :) |
Just floating this out: how about |
|
Fixes #248.
Hey look, I have a minimally working version and didn't take that long once I got around to this.
Screencast.from.07-10-2024.04.52.50.PM.webm
This isn't the all-in-one data analysis that @nmarkowitz was suggesting, it's just a different mode to view the data in for quality check purposes and if no one reads the help menu and knows to press "f", the browser won't be effected. How it works is that the TFR data is computed on the fly only for the times in view. Will add tests and clean up etc. but it would be nice to get feedback if anyone thinks of things. For instance, there is no way to tell the frequencies at the moment which seems like a bit of an issue. Also, might run slow on a less powerful computer but you can also limit your selection to a smaller time and channel range.