Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH, WIP: Spectrogram mode, minimal version #272

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alexrockhill
Copy link

Fixes #248.

Hey look, I have a minimally working version and didn't take that long once I got around to this.

Screencast.from.07-10-2024.04.52.50.PM.webm

This isn't the all-in-one data analysis that @nmarkowitz was suggesting, it's just a different mode to view the data in for quality check purposes and if no one reads the help menu and knows to press "f", the browser won't be effected. How it works is that the TFR data is computed on the fly only for the times in view. Will add tests and clean up etc. but it would be nice to get feedback if anyone thinks of things. For instance, there is no way to tell the frequencies at the moment which seems like a bit of an issue. Also, might run slow on a less powerful computer but you can also limit your selection to a smaller time and channel range.

@alexrockhill
Copy link
Author

alexrockhill commented Jul 11, 2024

  • Showing more channels results in traces instead of spectrograms
  • Add tests
  • Add change frequency menu

@larsoner
Copy link
Member

I would say at a minimum you'd need some way to specify / change the frequency range and the colormap limits. Seems like maybe a new dedicated TFR / spectrogram dialog might be needed, or if it's just a few options more rows in the existing Settings dialog could work

@nmarkowitz
Copy link
Contributor

I would say at a minimum you'd need some way to specify / change the frequency range and the colormap limits. Seems like maybe a new dedicated TFR / spectrogram dialog might be needed, or if it's just a few options more rows in the existing Settings dialog could work

I'm already expanding the settings dialog quite a bit with my project. Maybe we should add to remove channel scaling/sensitivity when in spectrogram mode? Probably isn't useful in this scenario.

@larsoner
Copy link
Member

Maybe we should add to remove channel scaling/sensitivity when in spectrogram mode? Probably isn't useful in this scenario.

Yeah it probably does make sense to show/hide based on viewing mode at some point. For now though I think it's okay to keep adding stuff and we can decide later what makes the most sense to show when, or whether to use tabs or different dialogs, etc. Make it work then make it pretty :)

@alexrockhill
Copy link
Author

Just floating this out: how about +/- to zoom in/out on the colormap which uses existing functionality and then shift+f to pop up a fmin/fmax dialog?

@larsoner
Copy link
Member

+/- makes sense since when not in traces mode it shouldn't matter. But for now rather than a separate dialog I'd put everything in settings then later we can decide the best places to split things out, or use tabs, or show/hide, etc.

@alexrockhill
Copy link
Author

image

Here's how it looks now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Spectrogram viewer
3 participants