DOC: glossary for minimum-norm estimate #6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Oct 1, 2019
doc/glossary.rst
Outdated
|
|
||
| minimum-norm estimation | ||
| Minimum-norm estimation (abbr. ''MNE'') can be used to generate a distributed | ||
| map of activation on a :term:'source space', usually on a cortical surface. |
There was a problem hiding this comment.
probably need backticks rather than single quotes on these to get it to render properly in Sphinx
agramfort
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
this tells me that an entry for noise covariance in glossary would be useful.
thx @klankinen
Codecov Report
@@ Coverage Diff @@
## master #6865 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 425 425
Lines 76004 76004
Branches 12398 12398
=======================================
Hits 68125 68125
Misses 5102 5102
Partials 2777 2777 |
|
Looks good! Here is the rendering: https://15787-1301584-gh.circle-artifacts.com/0/dev/glossary.html#term-minimum-norm-estimation |
|
Merging without waiting for Travis / Azure since this only touches the docs pages. Thanks @klankinen! |
alexrockhill
pushed a commit
to alexrockhill/mne-python
that referenced
this pull request
Oct 3, 2019
* DOC: glossary for minimum-norm estimate * Corrected quote marks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "minimum-norm estimate to the glossary"
@drammock