added definition of beamformer to the glossary #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Oct 1, 2019
doc/glossary.rst
Outdated
| @@ -24,6 +24,9 @@ general neuroimaging concepts. If you think a term is missing, please consider | |||
| object class and :ref:`tut-annotations` | |||
| for a tutorial on how to manipulate such objects. | |||
|
|
|||
| Beamformer | |||
| Beamformer is a popular source estimation approach that uses a set of spatial filters (beamformer weights) to compute time courses of sources which coordinates are predefined. Beamformer weight for a particular source is selected so it minimizes average reconstructed source power at a given location, subject to a unit gain constraint. See :class:`mne.beamformer.Beamformer’. | |||
There was a problem hiding this comment.
not all beamformers have the unit gain constraint. I would just remove the sentence Beamformer weight for a ... constraint.
Codecov Report
@@ Coverage Diff @@
## master #6864 +/- ##
==========================================
- Coverage 89.63% 88.39% -1.25%
==========================================
Files 425 425
Lines 76004 76003 -1
Branches 12398 12398
==========================================
- Hits 68125 67180 -945
- Misses 5102 6044 +942
- Partials 2777 2779 +2 |
agramfort
approved these changes
Oct 1, 2019
|
Thanks @NataKozh |
alexrockhill
pushed a commit
to alexrockhill/mne-python
that referenced
this pull request
Oct 3, 2019
* added definition of beamformer to the glossary * Glossary changes: definitions of beamformer and digitization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added definition of beamformer to the glossary
@drammock