Make mne/digitization private mne/_digitization #6697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massich
force-pushed
the
make_digitization_private
branch
from
f12fe3f
to
ab27c88
Compare
|
Does anyone know why the CIs do not do what I expect??? they are not running. |
massich
force-pushed
the
make_digitization_private
branch
from
30066de
to
c9cb583
Compare
agramfort
reviewed
Aug 22, 2019
| @@ -50,7 +50,7 @@ Changelog | |||
|
|
|||
| - Speed up morph map generation in :func:`mne.read_morph_map` by ~5-10x by using :func:`numba.jit` by `Eric Larson`_ | |||
|
|
|||
| - Add :class:`mne.digitization.Digitization` class to simplify montage by `Joan Massich`_ | |||
| - Add ``Digitization`` class to simplify montage by `Joan Massich`_ | |||
There was a problem hiding this comment.
can you now remove this entry?
There was a problem hiding this comment.
the whole thing? sure.
|
yes. Digitization is not anything that should be advertised anymore.
… |
|
closed in favor of #6700 (I've no idea why was not working. moving on!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review. this goes after #6639