Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Change DigMontage representation to use Digitization #6639
MNT: Change DigMontage representation to use Digitization #6639
Changes from 36 commits
f3ddcaf
b524af6
1d8888c
2f118b1
af87f24
d20d1e3
45f5a6e
23a3a18
052193c
8901f13
2f28847
03aace4
f8110c2
f0f16ce
041de69
2ec3d37
9beef17
694587e
f40bbfe
f28b26f
d2cd65a
61aeb41
54851f2
f2d0325
e534413
78f11cc
175e4cb
136bf89
351214e
69f3c34
feb4d12
eec13fb
deaa80a
fd09584
c0aa751
6fc46e8
56e6884
278d813
723deb7
668ac05
edf7571
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to
mne-python/mne/digitization/_utils.py
Line 42 in cc0391d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change how we write functions here? Everywhere else in MNE we do:
We also never use underscore vars for
args/kwargs
. For codebase consistency please fix theseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. But this is only here for a really short period of time. This function were just for convenience, and to keep track of all internal things for the refactoring.
I can change them to not
_foo
. But they day in the next PR.