-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Deprecate montage param from all EEG raw readers #6534
Conversation
crap my master was behind :( :( @massich I tried to the job with what i consider a dumb approach.... |
a63c927
to
0530a7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6534 +/- ##
==========================================
- Coverage 89.34% 89.33% -0.01%
==========================================
Files 416 416
Lines 74865 74889 +24
Branches 12341 12344 +3
==========================================
+ Hits 66885 66905 +20
- Misses 5137 5138 +1
- Partials 2843 2846 +3 |
This pull request introduces 1 alert when merging 05217a8 into 201ce50 - view on LGTM.com new alerts:
|
we have the same error on master now https://travis-ci.org/mne-tools/mne-python/jobs/555779112 not sure about the circle failure though |
|
This pull request introduces 1 alert when merging 53bf894 into 7d64af3 - view on LGTM.com new alerts:
|
This PR only deprecates that montage has to be None. It does not deprecate the montage parameter itself. |
add1da1
to
92c1061
Compare
This pull request introduces 1 alert when merging 92c1061 into 964ea6c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually in the messages we say explicitly when it will be removed, in this case 0.20. otherwise LGTM +1 for merge
done
… |
This pull request introduces 1 alert when merging 5ffe301 into 26231ff - view on LGTM.com new alerts:
|
+1, once travis is green I'll fix the whatsnew and merge it. |
This pull request introduces 1 alert when merging 56986b7 into 2b11463 - view on LGTM.com new alerts:
|
we should not be able to create info with montage shuold we? |
it should be possible but accepting a Digitization instance should be aimed for.
|
alternative to #6526