Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add montage parameter to BaseRaw #6462

Closed
wants to merge 1 commit into from

Conversation

massich
Copy link
Contributor

@massich massich commented Jun 17, 2019

This PR adds montage parameter in BaseRaw

@massich
Copy link
Contributor Author

massich commented Jun 17, 2019

So far this PR does something really dummy. It takes info[dig] which has been populated by _read_raw_file with a Digitization object and re-assigns it to info['dig'].

But this already raises some questions:
1 - who should have the set_montage responsibility? IMHO it should exposed through raw object (from channels mixin as it is it's fine), but it should be done in meas_info. Right now is done in montage.

2 - how can I separate to get 'dig' from the info reading in here:

info, meas = read_meas_info(fid, tree, clean_bads=True)

cc: @agramfort, @larsoner

@massich massich mentioned this pull request Jun 17, 2019
19 tasks
@agramfort
Copy link
Member

not the route we decided to follow

@agramfort agramfort closed this Jun 21, 2019
@massich massich deleted the add_montage_to_baseraw branch June 26, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants