Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG/ENH: apply_inverse_cov #6262
MRG/ENH: apply_inverse_cov #6262
Changes from all commits
303f1aa
65bc620
e7d5472
1491ff2
2a159fc
77c1427
866ab8d
ebd8e07
819d491
f73745d
e42f876
d1f0e23
7fa8564
e68cc43
ccea55f
8f57d99
bb7342b
a099541
8239f18
f23ce15
2ef5eaf
ffee32a
c15dfbe
3152e4e
aca1135
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@britta-wstnr @agramfort thanks for the comments, pushed a commit to address them. In the example I linked to
:term:
s instead of giving the definitions there, which caused me to addLCMV
andDICS
to ourglossary.rst
. @britta-wstnr can you just check to see if this is okay? If it's not, let me know how to modify it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@britta-wstnr I'll merge this once CIs come back happy, but feel free to open a PR to correct the wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsoner, thanks it is on my list to look at the glossary also with the beamformer tutorial I am writing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @britta-wstnr if you can get to the tutorial in the next couple of weeks it can make it into 0.20!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do all I can! It has been on my to do list for way too long already anyway 🙈 ... the workload has been high the last couple months.