-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG][DOC] Add GFP to the glossary #5804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5804 +/- ##
==========================================
+ Coverage 89.32% 89.33% +<.01%
==========================================
Files 408 408
Lines 74303 74303
Branches 12293 12293
==========================================
+ Hits 66374 66376 +2
+ Misses 5072 5070 -2
Partials 2857 2857 |
In order to be write an honest glossary entry for GFP, we would need to do it the same way everywhere. Sadly that is not happening:
(The first two methods are equivalent, but the last one is not) |
Perhaps some of the confusion arises because for EEG data with a common average reference the RMS power at each time point across sensors is the same as the standard deviation (but without CAR it's not due to the mean subtraction step). I'm actually not sure which we should use everywhere, probably the |
@larsoner it strikes me as low priority, but to improve consistency (and ensure future additions remain consistent) WDYT about adding a GFP function that triages based on instance type (and maybe incorporates some of the baselining functionality that @dengemann is using in that time-freq-GFP example?) |
Sure, a private function would be nice. It might not even need to triage based on type, it's entirely possible the |
This PR continues #5796 by adding an entry to the glossary and pointing at it.
@jona-sassenhagen can you (or anybody else) edit the glossary entry with
meaningful info? Thx. I think it would be good also to point to back to whatever
tuto/example explains better GFP.
(maybe
examples/time_frequency/plot_time_frequency_global_field_power.py
?)