Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some ._filenames uses in favor of .filenames #12996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sappelhoff
Copy link
Member

following #12843

I think it'd be good to reduce the use of private attributes in our own code base as well, if we might as well use the public attribute.

mne/io/base.py Outdated Show resolved Hide resolved
@larsoner
Copy link
Member

I don't have time to look deeply yet, just a quick comment that in the PR where we made the switch to paths and a public attribute, at some point I used git grep and tried to change the ones that I thought made sense to change, and left ones behind that didn't make sense to change or couldn't be changed. It's entirely possible I missed a few or I was wrong about what couldn't be changed though!

@sappelhoff
Copy link
Member Author

@larsoner @cbrnr the fix in c40c6f4 seems to have solved the failing tests. I believe the changes here can truly be converted to use the public attribute.

@cbrnr
Copy link
Contributor

cbrnr commented Nov 29, 2024

That's great and 👍 for merging, but I am still a bit concerned why only raw._filenames and not raw.filenames works, as these two are supposed to point to the same object, or no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants