-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove versions from README.rst #12889
Conversation
Historically I think we wanted them in the README since you see it clearly when you land on the MNE-Python repo. It does look like pandas at least lists dependencies in their README, so we're not alone in this. It would be nice to at least list/keep the minimum required dependencies. Those don't change all that often. The optional ones do and will much more easily get out of date -- and we have typically nice error messages when you don't have them -- so I'm okay with removing those. One problem with the current PR is that currently the README is actually the source of truth for our minimums in practice, believe it or not! See for example https://github.com/mne-tools/mne-python/wiki/How-to-make-a-major-or-minor-release#bump-minimums and release PRs like https://github.com/mne-tools/mne-python/pull/12798/files where those versions change concurrently with our code. So we'd need a new process for this. I guess it could be to keep everything in |
Ah yes, we should move this to pyproject.toml then (there are some version specifiers in there already, but I didn't know that we actually used our README). I'm fine with listing the core dependencies, these will have to be manually synced on every release (or whenever someone modifies them in |
We already parse package metadata (ultimately from Lines 1297 to 1300 in 53f258d
We could do something similar with our README (i.e., a pre-commit hook that updates the README whenever min versions are changed in |
I wouldn't do that, let's not add more magic to things that could be simple. If someone needs to know the exact requirements, they should refer to |
I guess we have different definitions of "magic" 🧙🏻 --- to me, this is "sensible automation to reduce the manual work needed to keep things from getting out of sync / inaccurate". I also think there are many users who might end up on our repo webpage and not know what So I am +1 for automating the |
+1 for removing entirely from README. |
To me |
I've removed the dependency list, because it is constantly out of sync with the actual requirements. In addition, I don't think that we need to feature them that prominently in the README, since all the information is contained in the metadata anyway.