-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add splash for coreg gui #10412
Conversation
@larsoner This looks great. |
This already works since it's just a backend thing: Peek.2022-03-04.10-57.mp4By my estimation it's about 2.5 sec from start until it shows up: Peek.2022-03-04.10-57.mp4
Yes, that and a Qt application. But unfortunately, both of these have to complete before the splash is shown. So really it's useful if displaying the window itself is the slow part. Looks like it does at least show up if I add it to mne-qt-browser: Peek.2022-03-04.11-01.mp4 |
Nice work, @larsoner! Can we make the splash screen
And it shouldn't obfuscate the entire screen e.g. |
* upstream/main: MNT: Test notebook (mne-tools#10411) ENH: check coreg output subject name (mne-tools#10378)
looks great ! |
@GuillaumeFavelier feel free to merge if you're happy. @hoechenberger we can always improve the splash image in follow-up PRs! |
wait 3000 additions? I have to look. |
That's just the |
oh. |
@larsoner Amazing work, I love it! |
Well, Eric's been busy, you see! 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great for me 👌 !
Thank you @larsoner |
Speaking of visual feedback while we're doing something: mme sys_info easily takes 20, 30 seconds on my computer and sometimes a minute or even several minutes (!) on certain network-based installs I'm using. And I think on my M1 Mac it took about 3 minutes to return anything in the first run (through Rosetta 2). Any chance we could at least let users know that we're still alive there? |
Do you think a progress bar in the terminal would help? |
I think it's a bit of a corner case in that users will typically not hit because vtk and mpl are super slow for their first import (only). You hit it as a dev using CIs because they have fresh envs all the time. So I'd rather not make this a lot more complicated. One easy change is to make outputs incremental as we accumulate each bit of information. The way it works now, we construct the whole string and then print it all at once. Doing it incrementally will also add a tiny hint of information, namely what takes so long. |
... I can make a quick PR for this today |
This sounds reasonable to me, what do you think @hoechenberger ? |
The coreg gui loads a lot of stuff -- it takes 3-4 sec to come up on my system (see below). This PR adds a splash screen so that the user knows that something is happening:
Peek.2022-03-04.09-52.mp4
@hoechenberger if you agree this is good, I could make a quick proper MNE splash screen, since the one here is just a placeholder. Maybe the MNE logo on a white background with rounded corners?
cc @marsipu in principle you could use this for mne-qt-browser, too, but your GUI always comes up very quickly so I don't think it's necessary...