Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC, MRG] Small fixes #10381

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[DOC, MRG] Small fixes #10381

merged 1 commit into from
Feb 22, 2022

Conversation

alexrockhill
Copy link
Contributor

Fixes leftovers from #10373

@alexrockhill
Copy link
Contributor Author

What should I have skipped for just doc? Is it [skip ci]? I think that still runs the make docstring test right?

@larsoner
Copy link
Member

I would have pushed with [skip azp] [skip actions], then just CircleCI will run, which should check our docstrings. You could also add [circle skip] as even with [skip azp], the style Azure job runs.

Don't push with [skip ci] because then (I think?) even then Azure won't run anything, including style

@alexrockhill
Copy link
Contributor Author

Okay, thanks!

@alexrockhill
Copy link
Contributor Author

Looks good to go

@agramfort agramfort merged commit 3c3c876 into mne-tools:main Feb 22, 2022
larsoner added a commit to larsoner/mne-python that referenced this pull request Feb 23, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into gui
ba67e64 
* upstream/main:
  FIX: close_connect (mne-tools#10388) [circle deploy]
  FIX: Bump deps (mne-tools#10376)
  [DOC] Small fixes [skip azure] [skip actions] (mne-tools#10381)
  FIX: coreg status bar (mne-tools#10368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrockhill @larsoner @agramfort