Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: test coreg UI with notebook 3d backend #10291

Merged
merged 4 commits into from
Feb 2, 2022
Merged

MNT: test coreg UI with notebook 3d backend #10291

merged 4 commits into from
Feb 2, 2022

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Feb 2, 2022 •
edited
Loading

This PR adds testing of the coreg UI with the notebook 3d backend. It's a very basic test for now.

The notebook app was hanging when loading trans locally, I'll add it to #8833:

  • the app hangs when loading trans (ipywidgets)

@GuillaumeFavelier GuillaumeFavelier self-assigned this Feb 2, 2022
@GuillaumeFavelier
Copy link
Contributor Author

What do you think @larsoner ?

@larsoner
Copy link
Member

larsoner commented Feb 2, 2022

Nice and clean, thanks @GuillaumeFavelier !

@larsoner larsoner merged commit 7a8964a into mne-tools:main Feb 2, 2022
@GuillaumeFavelier GuillaumeFavelier deleted the tst/notebook branch February 2, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeFavelier @larsoner