-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write optical density data in SNIRF format #511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 95.44% 95.47% +0.02%
==========================================
Files 69 69
Lines 2791 2830 +39
Branches 400 403 +3
==========================================
+ Hits 2664 2702 +38
Misses 63 63
- Partials 64 65 +1
|
Great PR @florin-pop. I made some suggestions that I think will simplify the code and slightly boost test coverage. Could you please check if they actually work? And add a changelog entry then ping us for a review/merge. Thanks! |
@larsoner I noticed that after you merged mne-tools/mne-python#11665 this line started failing in CI
Should we replace it with: with pytest.raises(ValueError, match='could not be picked'): ? |
I was thinking of doing something like:
but I'm not sure
|
I would use
|
Tests are green. Thanks @florin-pop @larsoner |
Fixes #456
Write optical density data in SNIRF format.
Example usage:
Contributed with ❤️ by AE Studio