MRG: Allow to specify custom landmark names in get_head_mri_trans() #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
changed the title
|
This is ready for review. I'm not particularly proud of that code, but it does do the job! |
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
==========================================
+ Coverage 94.39% 94.41% +0.01%
==========================================
Files 25 25
Lines 3550 3562 +12
==========================================
+ Hits 3351 3363 +12
Misses 199 199
Continue to review full report at Codecov.
|
agramfort
reviewed
Jan 19, 2022
doc/whats_new.rst
Outdated
| @@ -40,6 +40,8 @@ Enhancements | |||
|
|
|||
| - Add support for CNT (Neuroscan) files in :func:`mne_bids.write_raw_bids`, by `Yorguin Mantilla`_ (:gh:`924`) | |||
|
|
|||
| :func:`mne_bids.get_head_mri_trans` gained a new parameter, ``landmark_names``, allowing to specify custom names used for the anatomical landmarks in the MRI data, by `Richard Höchenberger`_ (:gh:`xxx`) | |||
I hear you and +10000 this. Well, what can we do, we ain't gonna fix this anytime soon ... |
hoechenberger
commented
Jan 19, 2022
|
Superseded by #955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mne-tools/mne-python#10208 (comment) is for why this is useful.
Merge checklist
Maintainer, please confirm the following before merging: