Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for optional Z in time strs #1240

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Conversation

sappelhoff
Copy link
Member

PR Description

fix a problem that was reported here: https://mne.discourse.group/t/how-to-import-fnirs-data-from-a-local-dataset/8481/3?u=sappelhoff

cc @hoechenberger

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

mne_bids/read.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (87eea28) to head (8566784).
Report is 15 commits behind head on main.

❗ Current head 8566784 differs from pull request most recent head f907308. Consider uploading reports for the commit f907308 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   97.61%   97.60%   -0.02%     
==========================================
  Files          40       40              
  Lines        8685     8682       -3     
==========================================
- Hits         8478     8474       -4     
- Misses        207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff marked this pull request as draft March 20, 2024 18:45
@hoechenberger
Copy link
Member

@sappelhoff I tried to give it a shot

Code isn't super pretty but I think the logical flow is very clear

Didn't run or write any tests yet

@hoechenberger
Copy link
Member

I added some tests

@hoechenberger hoechenberger marked this pull request as ready for review March 25, 2024 13:06
mne_bids/read.py Outdated Show resolved Hide resolved
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be good to go. Another example of a poorly designed part of BIDS, unfortunately.

Copy link
Member Author

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot! Would you mind adding a changelog entry?

@sappelhoff sappelhoff added this to the 0.15 milestone Mar 25, 2024
@sappelhoff sappelhoff enabled auto-merge (squash) March 25, 2024 13:59
@sappelhoff
Copy link
Member Author

sappelhoff commented Mar 25, 2024

Very kind of you to include me in the commit changelog message 🤣

Thanks, I think this is much saner behavior now!!

@hoechenberger
Copy link
Member

Very kind of you to include me in the commit changelog message 🤣

yeah now worries, you started the PR after all :)

Thanks, I think this is much saner behavior now!!

let's hope I / we didn't overlook something here … but I think in any case, we're behaving more correctly now than before!

@sappelhoff sappelhoff merged commit c75ac58 into mne-tools:main Mar 25, 2024
17 checks passed
@sappelhoff sappelhoff deleted the time branch March 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants