Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] add CSS to truncate long version string #1206

Merged
merged 2 commits into from
Dec 9, 2023
Merged

[MRG] add CSS to truncate long version string #1206

merged 2 commits into from
Dec 9, 2023

Conversation

drammock
Copy link
Member

@drammock drammock commented Dec 8, 2023 •
edited by sappelhoff
Loading

PR Description

closes #1205 by truncating long version strings (with text-overflow: ellipsis)

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@welcome Welcome
Copy link

welcome bot commented Dec 8, 2023

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@drammock
Copy link
Member Author

drammock commented Dec 8, 2023

Doc build is failing with

FileNotFoundError: File does not exist: "/home/circleci/mne_bids_env/lib/python3.9/site-packages/mne/data/fsaverage/fsaverage-fiducials.fif"

https://app.circleci.com/pipelines/github/mne-tools/mne-bids/5724/workflows/eec55885-c064-4fb8-83a2-825269e3fb48/jobs/7919

I'll push the changelog entry but @sappelhoff can you take over here?

@hoechenberger hoechenberger mentioned this pull request Dec 8, 2023
Merged
1 task
@hoechenberger
Copy link
Member

I can fix the issue

@cbrnr @larsoner @sappelhoff

@larsoner larsoner mentioned this pull request Dec 8, 2023
Closed
hoechenberger added a commit to hoechenberger/mne-python that referenced this pull request Dec 8, 2023
@hoechenberger
Clean up .gitignore a bit and fix packaging
e00d854 
Fixes packaging bug introduced in mne-tools#12269

Addresses the issues raised in:
mne-tools/mne-bids-pipeline#825 (comment)

mne-tools/mne-bids#1206 (comment)

Ultimately, we should start testing the installed package(s), not simply
fire up the tests from the root of the checked-out repo.
@hoechenberger hoechenberger mentioned this pull request Dec 8, 2023
Merged
@larsoner
Copy link
Member

larsoner commented Dec 8, 2023

Sure, I opened mne-tools/mne-python#12280 which will hopefully at least set up CIs to show the problem

hoechenberger added a commit to hoechenberger/mne-python that referenced this pull request Dec 8, 2023
@hoechenberger
Clean up .gitignore a bit and fix packaging
a6dde70 
Fixes packaging bug introduced in mne-tools#12269

Addresses the issues raised in:
mne-tools/mne-bids-pipeline#825 (comment)

mne-tools/mne-bids#1206 (comment)

Ultimately, we should start testing the installed package(s), not simply
fire up the tests from the root of the checked-out repo.
sappelhoff
sappelhoff reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Dan! Waiting for the other bug to be fixed to check out how this looks.

@hoechenberger hoechenberger reopened this Dec 8, 2023
@hoechenberger hoechenberger enabled auto-merge (squash) December 8, 2023 22:06
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8321aef) 97.61% compared to head (4716860) 97.61%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          40       40           
  Lines        8685     8685           
=======================================
  Hits         8478     8478           
  Misses        207      207

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drammock
Copy link
Member Author

drammock commented Dec 8, 2023

here's the rendered doc: https://output.circle-artifacts.com/output/job/a36b9461-2f17-4d84-ba0a-70d85c36c8cd/artifacts/0/dev/index.html

Looks as expected:
Screenshot 2023-12-08 at 16-16-40 MNE-BIDS — MNE-BIDS 0 15 0 dev17 g47168603 documentation

codecov failure seems spurious.

@drammock drammock changed the title add CSS to truncate long version string [MRG] add CSS to truncate long version string Dec 8, 2023
sappelhoff
sappelhoff approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thanks a ton @drammock!

codecov failure seems spurious.

yes, we do get these spurious analyses a lot, we should look into it.

@sappelhoff sappelhoff merged commit 5e4c76e into mne-tools:main Dec 9, 2023
30 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 9, 2023

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

@drammock drammock deleted the truncate-version branch January 17, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After switch to hatchling&hatch-vcs: heading in documentation is taking up too much space
4 participants
@drammock @hoechenberger @larsoner @sappelhoff