Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin sphinx < 6.0 #1115

Merged
merged 1 commit into from
Jan 2, 2023
Merged

pin sphinx < 6.0 #1115

merged 1 commit into from
Jan 2, 2023

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Jan 2, 2023

PR Description

fixes current circleci issues ... but I have no clue about what's the actual problem.

See here: https://app.circleci.com/pipelines/github/mne-tools/mne-bids/4980/workflows/2e885df3-ebb4-4a46-9b83-16decafba847/jobs/7129

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #1115 (058f53e) into main (0c83b75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          40       40           
  Lines        8670     8670           
=======================================
  Hits         8240     8240           
  Misses        430      430           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger hoechenberger enabled auto-merge (squash) January 2, 2023 12:46
@hoechenberger hoechenberger merged commit 4c32752 into mne-tools:main Jan 2, 2023
@sappelhoff sappelhoff deleted the sphinx branch January 2, 2023 13:16
@drammock
Copy link
Member

drammock commented Jan 3, 2023

I have no clue about what's the actual problem

sphinx 6.0 removed built-in variable "logo" in favor of "logo_url". It's being fixed at the theme level (in-progress) pydata/pydata-sphinx-theme#1097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants