-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for autoreject
(local) before running ICA
#810
Conversation
autoreject_local
before running ICAautoreject
before running ICA
autoreject
before running ICAautoreject
(global, local) before running ICA
c6199c4
to
fb37b5c
Compare
83bc925
to
7b6569e
Compare
Report: Tests are still taking too long, will look into this before we merge |
Do you need both Is there any autoreject doc / tutorial we can link to in order to help people decide? |
For ICA, the recommended way is using AR local before ICA (on the epochs that will be used for fitting), then clean the data with ICA, and running AR local again, this time on those cleaned epochs I think we didn't add AR global for pre-ICA cleaning in the past because it would reject just too many epochs. I could remove that option |
Official docs on AR & ICA: |
That said, I've used the existing AR global rejection after ICA successfully for a long time. So we should offer ica_reject: None | dict[str, float] | Literal["autoreject_local"]
reject: None | dict[str, float] | Literal["autoreject_local", "autoreject_global"] WDYT? |
@agramfort What's your feeling here? We didn't support AR global before ICA in the past. Maybe it should stay that way? But AR local before ICA makes total sense, I'm getting really nice results and much better decompositions than when using fixed global thresholds with my data |
autoreject
(global, local) before running ICAautoreject
(local) before running ICA
@larsoner I've removed support for global autoreject before ICA. |
Nice @hoechenberger ! |
Thanks @larsoner |
Before merging …
docs/source/changes.md
)