Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bug with cache invalidation #756

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jul 5, 2023

Before merging …

  • Changelog has been updated (docs/source/changes.md)

Closes #748

First run of ds004229 with the default epochs_tmax=1:

[13:04:08] ┌╴🚀 preprocessing/_05_make_epochs Now running  👇
[13:04:08] │ ⏳️ preprocessing/_05_make_epochs sub-102 Loading filtered raw data from sub-102_task-amnoise_proc-filt_raw.fif
[13:04:09] │ ⏳️ preprocessing/_05_make_epochs sub-102 Creating task-related epochs …

Next run correctly shows as cached:

[13:09:25] ┌╴🚀 preprocessing/_05_make_epochs Now running  👇
[13:09:25] │ ✅ preprocessing/_05_make_epochs sub-102 Computation unnecessary (cached) …
[13:09:25] └╴🎉 preprocessing/_05_make_epochs Done running  👆 [1s]

Change tmax to 2 it correctly re-runs:

[13:17:08] ┌╴🚀 preprocessing/_05_make_epochs Now running  👇
[13:17:08] │ ⏳️ preprocessing/_05_make_epochs sub-102 Loading filtered raw data from sub-102_task-amnoise_proc-filt_raw.fif
[13:17:09] │ ⏳️ preprocessing/_05_make_epochs sub-102 Creating task-related epochs …

On this PR, changing back to 1 correctly re-runs:

[13:18:29] ┌╴🚀 preprocessing/_05_make_epochs Now running  👇
[13:18:29] │ 🔂 preprocessing/_05_make_epochs sub-102 Output file hash mismatch, will recompute …
[13:18:29] │ ⏳️ preprocessing/_05_make_epochs sub-102 Loading filtered raw data from sub-102_task-amnoise_proc-filt_raw.fif
[13:18:30] │ ⏳️ preprocessing/_05_make_epochs sub-102 Creating task-related epochs …

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@hoechenberger hoechenberger enabled auto-merge (squash) July 6, 2023 06:02
@hoechenberger hoechenberger merged commit ccbac54 into mne-tools:main Jul 6, 2023
@larsoner larsoner deleted the cache branch July 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Bug with caching
3 participants