hide "outdoor" answer if there is no outdoor seating

as reported in streetcomplete#3856
mnalis · Mar 10, 2022 · 0e3e753 · 0e3e753
1 parent d6c5d48
commit 0e3e753
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/smoking/SmokingAllowedAnswerForm.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/smoking/SmokingAllowedAnswerForm.kt
@@ -15,10 +15,11 @@ class SmokingAllowedAnswerForm : AListQuestAnswerFragment<SmokingAllowed>() {
         val isAlreadyOutdoor =
             tags["leisure"] == "outdoor_seating" || tags["amenity"] == "biergarten" ||
             (tags["outdoor_seating"] == "yes" && tags["indoor_seating"] == "no")
+        val noOutdoorSeating = tags["outdoor_seating"] == "no"
 
         return listOfNotNull(
             TextItem(NO, R.string.quest_smoking_no),
-            if (isAlreadyOutdoor) null else TextItem(OUTSIDE, R.string.quest_smoking_outside),
+            if (isAlreadyOutdoor || noOutdoorSeating) null else TextItem(OUTSIDE, R.string.quest_smoking_outside),
             TextItem(SEPARATED, R.string.quest_smoking_separated),
             TextItem(YES, R.string.quest_smoking_yes),
         )