Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker generator #125

Merged
merged 40 commits into from
Jan 3, 2021
Merged

Marker generator #125

merged 40 commits into from
Jan 3, 2021

Conversation

floogulinc
Copy link
Member

@floogulinc floogulinc commented Aug 9, 2020

https://buzz-about-git-marker-generator.mn-pollinators.vercel.app/markers

This is currently working off the assumption that we change to AR_MATRIX_CODE_5x5_BCH_22_7_7 type markers, see #124.

@vercel
Copy link

vercel bot commented Aug 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mn-pollinators/buzz-about/337quhptd
✅ Preview: https://buzz-about-git-marker-generator.mn-pollinators.vercel.app

@floogulinc floogulinc self-assigned this Aug 9, 2020
@floogulinc
Copy link
Member Author

This will need to be changed to use AR_MATRIX_CODE_4x4_BCH_13_9_3. See #128

@cypress
Copy link

cypress bot commented Dec 25, 2020



Test summary

68 0 0 0


Run details

Project Buzz About
Status Passed
Commit 6e0739b
Started Jan 3, 2021 12:24 AM
Ended Jan 3, 2021 12:27 AM
Duration 02:46 💡
OS Linux Ubuntu - 18.04
Browser Electron 83

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Not including the other variants right now since we aren't using them
@floogulinc
Copy link
Member Author

floogulinc commented Dec 30, 2020

One thing to keep in mind is that just adding the pdfmake library has increased our main bundle size by about 1mb. It might be a good time to look at code-splitting so we can start only loading these large libraries (pdfmake, three-ar, etc) when needed. (#181)

@floogulinc
Copy link
Member Author

floogulinc commented Dec 30, 2020

We should look at browser support and potentially disable the print button where it's not supported.

See bpampuch/pdfmake#800 and https://pdfmake.github.io/docs/0.1/getting-started/client-side/supported-browsers/

audreylemeur
audreylemeur previously approved these changes Jan 2, 2021
Copy link
Member

@helloworld12321 helloworld12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm—thanks, Paul!

I've made a few review suggestions—it's mostly

  • rewording one thing in the UI
  • removing some unused methods
  • a bit of documentation
  • narrowing the type-checking on one field
  • some indentation + whitespace

None of that is super critical, though 🙂

(Also, if you disagree with any of the suggestions, I'd be happy to leave things as they are!)


By the way, thanks a million for getting all the PDF stuff done—looking at the libraries you're using, I'm reminded just how much I don't like working with PDFs, and how glad I am that I didn't have to implement any of this.

package.json Show resolved Hide resolved
src/app/custom-barcode-marker-generator.ts Outdated Show resolved Hide resolved
src/app/custom-barcode-marker-generator.ts Outdated Show resolved Hide resolved
@helloworld12321
Copy link
Member

Browser compatibility looks pretty good, by the way—I tested on Firefox, desktop Safari, and mobile Safari.

@helloworld12321
Copy link
Member

In the future, if we need to add anything to the PDF generation, I could see moving it to its own service. Right now, though, I think it's probably fine where it is 🙂

Co-authored-by: Joe Walbran <[email protected]>

Co-authored-by: Joe Moonan Walbran <[email protected]>
Copy link
Member

@helloworld12321 helloworld12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I'm going to give this a quick look over to make sure everything still works, and then I'll approve it :)

Copy link
Member

@helloworld12321 helloworld12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic—thanks, Paul.

@floogulinc floogulinc merged commit a286829 into master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants