-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marker generator #125
Marker generator #125
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mn-pollinators/buzz-about/337quhptd |
This will need to be changed to use |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Not including the other variants right now since we aren't using them
One thing to keep in mind is that just adding the pdfmake library has increased our main bundle size by about 1mb. It might be a good time to look at code-splitting so we can start only loading these large libraries (pdfmake, three-ar, etc) when needed. (#181) |
We should look at browser support and potentially disable the print button where it's not supported. See bpampuch/pdfmake#800 and https://pdfmake.github.io/docs/0.1/getting-started/client-side/supported-browsers/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm—thanks, Paul!
I've made a few review suggestions—it's mostly
- rewording one thing in the UI
- removing some unused methods
- a bit of documentation
- narrowing the type-checking on one field
- some indentation + whitespace
None of that is super critical, though 🙂
(Also, if you disagree with any of the suggestions, I'd be happy to leave things as they are!)
By the way, thanks a million for getting all the PDF stuff done—looking at the libraries you're using, I'm reminded just how much I don't like working with PDFs, and how glad I am that I didn't have to implement any of this.
Browser compatibility looks pretty good, by the way—I tested on Firefox, desktop Safari, and mobile Safari. |
In the future, if we need to add anything to the PDF generation, I could see moving it to its own service. Right now, though, I think it's probably fine where it is 🙂 |
Co-authored-by: Joe Walbran <[email protected]> Co-authored-by: Joe Moonan Walbran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! I'm going to give this a quick look over to make sure everything still works, and then I'll approve it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic—thanks, Paul.
https://buzz-about-git-marker-generator.mn-pollinators.vercel.app/markers
This is currently working off the assumption that we change to
AR_MATRIX_CODE_5x5_BCH_22_7_7
type markers, see #124.