Fix missing strbuf #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CI (and locally) we were seeing a failed assertion for the `test_gem_remote_fetcher` test. After much debugging it was clear that for this test the strbuf was missing on `shared` so when `orig` moved, `shared` didn't follow`. This caused the offset to be very off. ``` Assertion Failed: string.c:1805:str_new_frozen_buffer:ofs >= 0 ruby 3.4.0dev (2024-08-09T19:42:38Z reproduction-for-s.. a5b29b5277) +MMTk(Immix) [arm64-darwin23] ``` With a `GC_ASSERT` we tracked down a missing `rb_mmtk_str_set_strbuf` in `rb_str_tmp_frozen_no_embed_acquire`. Fixes: #85
eileencodes
force-pushed
the
mmtk-fix-missing-shared-strbuf
branch
from
defff97
to
ca89e44
Compare
|
I merged this PR because it does fix one missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI (and locally) we were seeing a failed assertion for the
test_gem_remote_fetchertest. After much debugging it was clear that for this test the strbuf was missing onsharedso whenorigmoved,shareddidn't follow`. This caused the offset to be very off.With a
GC_ASSERTwe tracked down a missingrb_mmtk_str_set_strbufinrb_str_tmp_frozen_no_embed_acquire.Fixes: #85