Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary include #66

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

eileencodes
Copy link
Collaborator

Previously there was code that conditionally changed with MMTK but that code was removed in the last sync with master.

That code was changed upstream in
ruby#10358. Since there are no if USE_MMTK calls in this file, we no longer need to include internal/mmtk_support.h.

Previously there was code that conditionally changed with MMTK but that
code was removed in the last sync with master.

That code was changed upstream in
ruby#10358. Since there are no `if
USE_MMTK` calls in this file, we no longer need to include
`internal/mmtk_support.h`.
@wks wks merged commit 83e1407 into mmtk:mmtk Apr 15, 2024
94 of 99 checks passed
@wks
Copy link

wks commented Apr 15, 2024

Thank you for pointing it out. I have merged this change, but I think I will soon add it back when I try to remove the underlying xmalloc buffer of non-embedded Object. I tried it once, but it was not very profitable, and I had some issues with object shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants