Remove code that iterates over bindings table #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when moving objects.
qinsoon
approved these changes
Aug 14, 2023
|
Cc: @d-netto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to remove code that iterates over bindings table within a module. This may cause issues because we load information from this table, and if/when we support moving, the fields loaded might be obsolete. Given that we process the edge
&m->bindings, it is not clear whether we need to iterate over the table when processing the module.Perhaps, before merging this PR we should consult with people familiar with Julia's stock GC to confirm that this change won't cause any unknown problems.
Note that this PR should close #49.