Move some states from BasePlan to GlobalState #949
Conversation
|
Nice work. This PR addressed some long-standing issues. Issue #532: The last work item in that issue is moving Issue #587: That issue mentioned some fields that were accidentally added to #587 (comment) also mentioned some previous static methods in JikesRVM MMTk. Those methods were in |
|
The refactoring seems to slow down the STW/GC time. I can't find an obvious reason that causes the slowdown. I will create separate PRs for a subset of changes, evaluate and merge them separately. |
|
The PR does not seem to have any measurable performance difference. The following is the total time for 4 plans, SemiSpace, GenCopy, Immix and GenImmix. More details can be found in the link: plotty SemiSpace
GenCopy
Immix
GenImmix
|
| // TODO: I don't know how this can be implemented when we have multiple MMTk instances. | ||
| // This function is used by space and phase to refer to the current plan. | ||
| // Possibly we should remove the use of this function, and remove this function? | ||
| fn global() -> &'static dyn Plan<VM = VM>; |
There was a problem hiding this comment.
I will update bindings for this change.
src/util/alloc/malloc_allocator.rs
Outdated
| /// [`Plan`] instance that this allocator instance is associated with. | ||
| plan: &'static dyn Plan<VM = VM>, | ||
| context: Arc<AllocatorContext<VM>>, | ||
| _pad: usize, |
There was a problem hiding this comment.
I am currently use a padding field to make sure the size of the allocator types stays the same as before. I plan to remove this field, and update the bindings.
|
@wks Can you review this PR? I haven't created binding PRs for it, but I would like to get some reviews for the PR first. Updating bindings should be straightforward after that. |
|
This PR is not ready for merge. The binding PRs need to be ready, reviewed and approved before we can merge this PR. |
|
binding-refs |
qinsoon
added
the
PR-testing
Updates to mmtk/mmtk-core#949. --------- Co-authored-by: mmtkgc-bot <[email protected]>
Updates to mmtk/mmtk-core#949 --------- Co-authored-by: mmtkgc-bot <[email protected]>
Updates to mmtk/mmtk-core#949. --------- Co-authored-by: mmtkgc-bot <[email protected]>
Updates to mmtk/mmtk-core#949. --------- Co-authored-by: mmtkgc-bot <[email protected]>
Updates to mmtk/mmtk-core#949. --------- Co-authored-by: mmtkgc-bot <[email protected]>
This PR moves some states from
BasePlanto a new structGlobalState. Before this change, the states can only be accessed throughPlan. Whoever needs to access those states need to acquire or store a reference toPlan, which is unnecessary. With the changes in the PR,GlobalStateis stored asArc<GlobalState>. It can be directly accessed through theMMTKinstance, and can also be stored in some components, such as allocators. This change reduces the dependency onPlan.