Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 binding test now uses the perf runner #333

Merged
merged 1 commit into from
May 26, 2021
Merged

V8 binding test now uses the perf runner #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/post-review-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
v8-binding-test:
runs-on: [self-hosted, linux, freq-scaling-on]
runs-on: [self-hosted, linux, freq-scaling-off]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to our performance tests?
Should we manually check that nothing else is running on the perf runner?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one runner on the perf machine. If a perf job is running, other jobs will be queued.

timeout-minutes: 60
if: contains(github.event.pull_request.labels.*.name, 'PR-testing')
steps:
Expand Down