Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pinning metadata to mock_vm #1121

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

wks
Copy link
Collaborator

@wks wks commented Apr 17, 2024

If the "object_pinning" feature is enabled, we add the LOCAL_PINNING_BIT_SPEC constant when implementing ObjectModel for MockVM. That fixes compilation error if we attempt to run cargo clippy with many features including both "mock_test" and "object_pinning", although we currently don't do mock tests for the pinning metadata.

@wks wks requested a review from qinsoon April 17, 2024 08:56
@qinsoon qinsoon added this pull request to the merge queue Apr 17, 2024
Merged via the queue into mmtk:master with commit 1bfd558 Apr 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants