Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly get PR number for merge group #1077

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 28, 2024

Run https://github.com/mmtk/mmtk-core/actions/runs/7649653943/job/20844445119 failed, as we use ${{ github.event.pull_request.number }} to get the pull request number and it does not work for the merge_group trigger. This PR gets pull request number using a third-party action which properly deals with both pull_request and merge_group.

@qinsoon qinsoon force-pushed the fix/pr-number-for-merge-group branch from 12ec162 to 8cbb472 Compare January 28, 2024 23:24
@qinsoon qinsoon force-pushed the fix/pr-number-for-merge-group branch from 8cbb472 to 2bcd502 Compare January 28, 2024 23:25
@qinsoon qinsoon marked this pull request as ready for review January 29, 2024 00:20
@qinsoon qinsoon requested a review from wks January 29, 2024 00:20
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Jan 29, 2024
@qinsoon qinsoon removed this pull request from the merge queue due to a manual request Jan 29, 2024
@qinsoon qinsoon force-pushed the fix/pr-number-for-merge-group branch from 69d8cfa to 2153c50 Compare January 29, 2024 03:22
@qinsoon qinsoon added this pull request to the merge queue Jan 29, 2024
Merged via the queue into mmtk:master with commit 42754a5 Jan 29, 2024
22 checks passed
@qinsoon qinsoon deleted the fix/pr-number-for-merge-group branch January 29, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants