Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binding write barrier for code gen #34

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 31, 2024

This PR makes a few changes about write barrier for bindings.

  • Move the code that sets gc bits to 2 in the binding write barrier into the slowpath
  • Generate code to set gc bits for binding write barrier.
  • Add unreachable() in a few jl_gc_wb methods in Julia to make sure they won't be accidentally called (Julia's GC does not inline write barrier, and won't need them).

Copy link

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qinsoon qinsoon merged commit 874179e into mmtk:v1.9.2+RAI Jan 31, 2024
3 checks passed
qinsoon added a commit to mmtk/mmtk-julia that referenced this pull request Feb 1, 2024
qinsoon pushed a commit to qinsoon/julia that referenced this pull request May 2, 2024
…g#53124)

Stdlib: ArgTools
URL: https://github.com/JuliaIO/ArgTools.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 4eccde4
New commit: 997089b
Julia version: 1.11.0-DEV
ArgTools version: 1.1.2(Does not match)
Bump invoked by: @vtjnash
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaIO/ArgTools.jl@4eccde4...997089b

```
$ git log --oneline 4eccde4..997089b
997089b fix tests for TEMP_CLEANUP, which might be a Lockable (mmtk#35)
4a5f003 build(deps): bump actions/cache from 3 to 4 (mmtk#36)
84ba9e8 Hardcode doc edit backlink (mmtk#34)
9238839 build(deps): bump actions/checkout from 3 to 4 (mmtk#33)
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants