Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Unsupported cargo-deb field systemd-units #147

Open
atoav opened this issue Sep 6, 2020 · 4 comments
Open

Unsupported cargo-deb field systemd-units #147

atoav opened this issue Sep 6, 2020 · 4 comments

Comments

@atoav
Copy link

atoav commented Sep 6, 2020

In my case the action fails because the field systemd-units in my Cargo.toml is unknown.

More precisely it is the field package.metadata.deb.systemd-units. I guess this might be due to an outdated version of cargo deb?

atoav added a commit to atoav/totmannschalter that referenced this issue Sep 6, 2020
Reason: They dont support the cargo-deb field package.metadata.deb.systemd-units yet. A PR has been made in mmstick/cargo-deb#147
@ximon18
Copy link
Contributor

ximon18 commented Sep 6, 2020

The functionality is in master and in the latest beta release but the actual release is still pending. AFAIK @kornelski was soliciting feedback on the beta before making a final release.

@atoav
Copy link
Author

atoav commented Sep 6, 2020

Ah great news

@ximon18
Copy link
Contributor

ximon18 commented Sep 7, 2020

FYI these GitHub Action runs from the Krill project use the systemd functionality in the master cargo-deb version, via command:

cargo install --git https://github.com/mmstick/cargo-deb.git --rev $CARGO_DEB_VER cargo-deb

Where CARGO_DEB_VER=94ba8f3.


Update: It should be possible to just do cargo install cargo-deb because the systemd units functionality is in the latest cargo-deb v1.28.0 release.

@ximon18
Copy link
Contributor

ximon18 commented Sep 9, 2020

Hi @atoav,

So, I was wrong, while there was not a GitHub v1.28.0 tag there was a v1.28.0 since August 17th (and several betas prior to that) on crates.io. @kornelski has just added the v1.28.0 tag here on GitHub but I understand from him that crates.io is the primary location where new versions are "released".

I see that you are using ebbflow-io/xxx cargo-deb packages, I don't know anything about those. Ah I see it is a GitHub Actions "action". It must have been built from an older version of cargo-deb. I'm afraid you'll need to take that up with the author of the action which looks like it might be https://github.com/gorup.

Perhaps it would be good if you could raise an issue on the actions GH issue tracker for the action marketplace page to be clear about which version of cargo-deb it uses?

I also use GH actions and to avoid the cargo install compilation cost I use GH caching to cache the result of the last time the cargo-deb binary was built. A GH action wrapping cargo-deb would be simpler to use so if the maintainer of the action intends to keep the action up-to-date and make it clear which version it uses it could be a very handy action!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants