Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add joint marginal imputation method for marginal imputer #261

Closed
mmschlk opened this issue Oct 29, 2024 · 0 comments · Fixed by #262
Closed

Add joint marginal imputation method for marginal imputer #261

mmschlk opened this issue Oct 29, 2024 · 0 comments · Fixed by #262
Assignees
@mmschlk
Labels
enhancement New feature or request imputer All issues linked to imputers
Milestone
v1.1.0

Comments

@mmschlk
Copy link
Owner

mmschlk commented Oct 29, 2024

Atm. only independent sampling of features is possible. However, in a lot of cases sampling from the joint marginal distribution is necessary to be statistically correct.

We need to extend MarginalImputer for this.
@mmschlk mmschlk added enhancement New feature or request imputer All issues linked to imputers labels Oct 29, 2024
@mmschlk mmschlk self-assigned this Oct 29, 2024
@mmschlk mmschlk moved this to 🏗 In progress in shapiq development Oct 29, 2024
@mmschlk mmschlk added this to the v1.1.0 milestone Oct 29, 2024
mmschlk added a commit that referenced this issue Oct 29, 2024
@mmschlk
adds test to joint marginal prediciton and closes #261
21d781c
@mmschlk mmschlk mentioned this issue Oct 29, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in shapiq development Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmschlk mmschlk

Labels
enhancement New feature or request imputer All issues linked to imputers
Projects
shapiq development
Status: ✅ Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Adds BaselineImputer and Reworks MarginalImputer mmschlk/shapiq
1 participant
@mmschlk