Add a stub/fake blog feed loader and use it for now. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module.exports = loadBlogFeed; | ||
|
|
||
| // TODO: Replace this with a real implementation. | ||
| module.exports = require('../test/browser/stub-blog-feed-loader'); |
There was a problem hiding this comment.
So basically after your accept this PR, don't touch this file 😁 It's where I'll be adding my code in a separate PR--most likely copying your original code and productionalizing it based on some of my suggestions in mozilla#943.
5 tasks
|
Awesome! Thanks a lot @toolness |
mmmavis
added a commit
that referenced
this pull request
May 27, 2015
Add a stub/fake blog feed loader and use it for now.
mmmavis
pushed a commit
that referenced
this pull request
Feb 15, 2016
code cleanup & set 'activeClassName' prop to TopLevelNavItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to reduce the complexity of implementing the new homepage: