Feature: Incorporate site search into masthead #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, nice!! |
Align search form with masthead links.
Place alongside main content and toggle between them instead of overlaying which produces messy scrollbar heights.
|
@ohadschn Thought you'd might enjoy this early holiday 🎁 |
Add .gif showing site search in action and how to enable it via _config.yml variable.
|
This is like the Hanukkah Miracle all over again! |
|
Looks Great! |
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
* Integrate search into masthead * Fix cutoff descenders in archive article titles * Remove search page from `/test` site * Enable masthead search * Remove dedicated search page * Fix masthead search form padding * Improve insertion of search content * Speed up page transition * Add fade transition to search content * Rename visibility class names * Add `site.search` to _config.yml * Document site search feature * Update CHANGELOG and history
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this pull request
Sep 10, 2019
* Integrate search into masthead * Fix cutoff descenders in archive article titles * Remove search page from `/test` site * Enable masthead search * Remove dedicated search page * Fix masthead search form padding * Improve insertion of search content * Speed up page transition * Add fade transition to search content * Rename visibility class names * Add `site.search` to _config.yml * Document site search feature * Update CHANGELOG and history
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
* Integrate search into masthead * Fix cutoff descenders in archive article titles * Remove search page from `/test` site * Enable masthead search * Remove dedicated search page * Fix masthead search form padding * Improve insertion of search content * Speed up page transition * Add fade transition to search content * Rename visibility class names * Add `site.search` to _config.yml * Document site search feature * Update CHANGELOG and history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
site.search == truein _config.yml_layout/search.htmland masthead search not playing nice together. Deprecate search layout?Example:
Ref #1011