-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split excerpt into archive_excerpt and overlay_excerpt #1429
Comments
The site wide boolean solution seems pretty minimally invasive, just the following to page__hero.html:
And adding overlay_excerpt: (true|false) to _config.yml |
If the above is acceptable, I can prepare a PR and update the documentation accordingly at the same time. |
One last thought for now. page.header.overlay_excerpt as a boolean is even better. More flexibility, no more invasive. |
So to clarify you're looking for a way to disable excerpts when using an image overlay? And not a way to specify different text for overlay excerpt and archive excerpts? The later is a complexity I'm not sold on. But using a boolean to disable overlay excerpts seems simple enough. |
Yes, for my purposes, the simple boolean is plenty. I'm currently using 'page.header.overlay_excerpt: false' and added that to the conditional in page__hero.html. Adding it to the default in the theme _config.yml to true I think would complete the feature and maintain existing behavior. If you're OK with this, I'll prepare the patch, docs, and PR. |
Make excerpts optional in header overlay Some posts and some header images don't lend themselves well to displaying the excerpt in the overlay. Make this optional by introducting a new boolean variable: `page.header.show_overlay_excerpt` Set it to implicitly default to `true` so existing users are unaffected by testing explicitly for "!= false". This can be enabled globally for a site by changing the default to `false` in the local _config.yml, or per page by specifying the value in front matter. Document show_overlay_excerpt variable * Add show_overlay_excerpt variable to the Header Overlay field documentation table. Close mmistakes#1429
Make excerpts optional in header overlay Some posts and some header images don't lend themselves well to displaying the excerpt in the overlay. Make this optional by introducting a new boolean variable: `page.header.show_overlay_excerpt` Set it to implicitly default to `true` so existing users are unaffected by testing explicitly for "!= false". This can be enabled globally for a site by changing the default to `false` in the local _config.yml, or per page by specifying the value in front matter. Document show_overlay_excerpt variable * Add show_overlay_excerpt variable to the Header Overlay field documentation table. Close mmistakes#1429
Make excerpts optional in header overlay Some posts and some header images don't lend themselves well to displaying the excerpt in the overlay. Make this optional by introducting a new boolean variable: `page.header.show_overlay_excerpt` Set it to implicitly default to `true` so existing users are unaffected by testing explicitly for "!= false". This can be enabled globally for a site by changing the default to `false` in the local _config.yml, or per page by specifying the value in front matter. Document show_overlay_excerpt variable * Add show_overlay_excerpt variable to the Header Overlay field documentation table. Close mmistakes#1429
bundle update
.bundle exec jekyll build
.Environment informations
Expected behavior
The "excerpt" is used in at least 2 unique ways:
a) archive grid (e.g. related)
b) recent posts (e.g. home)
At least in my case, I'm looking for different things for 1 and 2 above, and was looking for a way to kill the excerpt from the header overlay, while keeping it for the archive summary. I didn't find a way, so I ultimately just commented it out of page__hero.
https://dvhart.github.io/2015/04/05/wannabee-it-guy-kid-friendly-networking.html
I think it would be useful to split excerpt into overlay_excerpt and archive_excerpt, both of which default to excerpt, but can be independently overridden. Existing users wouldn't need to change anything as overriding excerpt would apply to both new fields. In my case I would set 'overlay_excerpt: ""' in defaults in my _config.yml, and leave archive_excerpt.
Another option might be to create a boolean for overlay_excerpt which just toggles if the excerpt is displayed in in the overlay header. This would be less flexible, but probably less invasive.
The text was updated successfully, but these errors were encountered: